yuris/titik-gambut-next
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

feat(map): 3D inverted TMAT groundwater deficit cylinders (#81) #118

Merged
yuris merged 1 commit from feat/tmat-3d-wells-layer into main 2026-10-15 05:17:50 +00:00
Conversation 1 Commits 1 Files changed 5 +385
yuris commented 2026-10-15 05:13:48 +00:00
Owner
Copy link

Summary

Renders TMAT groundwater stations as 3D inverted vertical cylinders descending beneath the terrain surface, visually highlighting subterranean combustion hazards when levels fall below -40 cm per PP 57/2016 (Issue #81).

Executed playbook: skill://poteto-mode/playbooks/feature.md.

Workstreams delivered

  • Implemented MapLibre fill-extrusion layer in src/components/map/layers/tmat-3d-wells-layer.tsx.
  • Integrated 3D well click telemetry popup rendering TmatPopup.
  • Added layer visibility toggle in layer-toggles.tsx.
  • Added unit tests in src/components/map/layers/__tests__/tmat-3d-wells-layer.test.ts.

Impact

  • For the consumer: Field officers can inspect subterranean peat groundwater depth directly in 3D perspective with color severity coding.
  • For the maintainer: Decoupled MapLibre layer management adhering to DESIGN.md tokens with 0 : any types.

Principles applied

  • principle-model-the-domain: Uses statutory PP 57/2016 groundwater deficit geometry models directly.
  • principle-boundary-discipline: Isolated MapLibre fill-extrusion layer state from React rendering.
  • principle-sequence-verifiable-units: Comprehensive unit tests verify extrusion paint properties and visibility states.

Verification proof

  • vp check: Clean formatting and 0 lint warnings.
  • vp test run: All unit tests pass.
## Summary Renders TMAT groundwater stations as 3D inverted vertical cylinders descending beneath the terrain surface, visually highlighting subterranean combustion hazards when levels fall below -40 cm per PP 57/2016 (Issue #81). Executed playbook: `skill://poteto-mode/playbooks/feature.md`. ### Workstreams delivered - Implemented MapLibre fill-extrusion layer in `src/components/map/layers/tmat-3d-wells-layer.tsx`. - Integrated 3D well click telemetry popup rendering `TmatPopup`. - Added layer visibility toggle in `layer-toggles.tsx`. - Added unit tests in `src/components/map/layers/__tests__/tmat-3d-wells-layer.test.ts`. ### Impact - **For the consumer:** Field officers can inspect subterranean peat groundwater depth directly in 3D perspective with color severity coding. - **For the maintainer:** Decoupled MapLibre layer management adhering to `DESIGN.md` tokens with 0 `: any` types. ### Principles applied - `principle-model-the-domain`: Uses statutory PP 57/2016 groundwater deficit geometry models directly. - `principle-boundary-discipline`: Isolated MapLibre fill-extrusion layer state from React rendering. - `principle-sequence-verifiable-units`: Comprehensive unit tests verify extrusion paint properties and visibility states. ### Verification proof - `vp check`: Clean formatting and 0 lint warnings. - `vp test run`: All unit tests pass.
feat(map): 3D inverted TMAT groundwater deficit cylinders (Issue #81)
All checks were successful
CI / Verify Quality & Build (pull_request) Successful in 1m52s
Details
54edf0259c
yuris-bot approved these changes 2026-10-15 05:17:39 +00:00
yuris-bot left a comment
Copy link

Code Review & Ponytail Audit Summary: 3D Inverted TMAT Groundwater Deficit Cylinders

1. Mechanical Verification Gate (scripts/verify-pr.mjs)

  • Passed all checks: title conventional format, mandatory principles citations, impact framing, and anti-overengineering file path filters.

2. Ponytail Audit (Zero Bespoke Bloat)

  • Layer Architecture: Lean MapLibre fill-extrusion implementation in src/components/map/layers/tmat-3d-wells-layer.tsx consuming pure geometric cylinders generated by @/lib/domain/tmat-3d.
  • Telemetry Popup: Directly mounts lightweight React component TmatPopup on click with standard cursor events.
  • Audit verdict: Lean already. Ship.

3. Subsystem Boundary & Discipline

  • Confined strictly to frontend domain (src/components/map/layers/tmat-3d-wells-layer.tsx, layer-toggles.tsx, map-view.tsx, dashboard-client.tsx). Zero backend or pipeline leakage.

4. Verification & Test Proofs

  • vp check: Passed 100% (286 files formatted, 0 warnings/lint errors in 123 files).
  • pnpm test: All 240 tests passed across 32 test suites.
  • next build: Next.js Turbopack build succeeded cleanly.
  • CI: Status check CI / Verify Quality & Build (pull_request) passed on Forgejo.

5. Acceptance Criteria

  • Verified and checked off all acceptance criteria checkboxes on linked Issue #81.

Decision: APPROVED for squash merge into main.

### Code Review & Ponytail Audit Summary: 3D Inverted TMAT Groundwater Deficit Cylinders #### 1. Mechanical Verification Gate (`scripts/verify-pr.mjs`) - Passed all checks: title conventional format, mandatory principles citations, impact framing, and anti-overengineering file path filters. #### 2. Ponytail Audit (Zero Bespoke Bloat) - **Layer Architecture**: Lean MapLibre fill-extrusion implementation in `src/components/map/layers/tmat-3d-wells-layer.tsx` consuming pure geometric cylinders generated by `@/lib/domain/tmat-3d`. - **Telemetry Popup**: Directly mounts lightweight React component `TmatPopup` on click with standard cursor events. - **Audit verdict**: `Lean already. Ship.` #### 3. Subsystem Boundary & Discipline - Confined strictly to frontend domain (`src/components/map/layers/tmat-3d-wells-layer.tsx`, `layer-toggles.tsx`, `map-view.tsx`, `dashboard-client.tsx`). Zero backend or pipeline leakage. #### 4. Verification & Test Proofs - `vp check`: Passed 100% (286 files formatted, 0 warnings/lint errors in 123 files). - `pnpm test`: All 240 tests passed across 32 test suites. - `next build`: Next.js Turbopack build succeeded cleanly. - CI: Status check `CI / Verify Quality & Build (pull_request)` passed on Forgejo. #### 5. Acceptance Criteria - Verified and checked off all acceptance criteria checkboxes on linked Issue #81. **Decision**: APPROVED for squash merge into `main`.
yuris merged commit 5abab3f105 into main 2026-10-15 05:17:50 +00:00
yuris deleted branch feat/tmat-3d-wells-layer 2026-10-15 05:17:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
yuris-bot
Labels
Clear labels   
backend
Backend task

  
frontend
Frontend task

No labels
backend
frontend
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/titik-gambut-next!118
No description provided.