yuris/garage
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages 1 Wiki Activity Actions

ci: ratchet biome-gate baseline and update biome.json schema #187

Merged
yuris merged 1 commit from ci/186-ratchet-biome-gate into main 2026-09-30 18:10:54 +00:00
Conversation 1 Commits 1 Files changed 2 +2 -8
yuris commented 2026-09-30 18:07:54 +00:00
Owner
Copy link

Closes #186.

What changed

  • Bump $schema in biome.json to 2.4.16 to match the active CLI.
  • Empty BASELINE in .forgejo/scripts/biome-gate.sh following elimination of all prior findings.

Verified

  • .forgejo/scripts/biome-gate.sh: PASSED (0 findings)
  • pnpm lint: clean across all workspace packages
  • pnpm test: all packages passed
  • pnpm --filter garage typecheck: 0 errors

Deviations

none

Closes #186. ## What changed - Bump `$schema` in `biome.json` to 2.4.16 to match the active CLI. - Empty `BASELINE` in `.forgejo/scripts/biome-gate.sh` following elimination of all prior findings. ## Verified - `.forgejo/scripts/biome-gate.sh`: PASSED (0 findings) - `pnpm lint`: clean across all workspace packages - `pnpm test`: all packages passed - `pnpm --filter garage typecheck`: 0 errors ## Deviations none
ci: ratchet biome-gate baseline and update biome.json schema
All checks were successful
Checks / test @garage/catalog (pull_request) Successful in 1m15s
Details
Checks / test garage (pull_request) Successful in 1m25s
Details
Checks / test garage-store (pull_request) Successful in 1m19s
Details
Checks / typecheck apps/management (pull_request) Successful in 1m38s
Details
Checks / lint (biome) (pull_request) Successful in 11s
Details
Checks / typecheck apps/store (pull_request) Successful in 1m23s
Details
1792091afc
yuris reviewed 2026-09-30 18:09:43 +00:00
yuris left a comment
Copy link

VERDICT: approve

Reviewed PR #187 against origin/main: the schema now matches Biome 2.4.16, and the empty baseline correctly removes the three eliminated diagnostics. The gate handles an empty baseline without failing its parsing/ratchet loops. No patch-introduced correctness issues found. The PR description reports the gate, lint, tests, and typecheck passing; I did not rerun them in this read-only review, and Forgejo CI checks were still pending when reviewed.

VERDICT: approve Reviewed PR #187 against origin/main: the schema now matches Biome 2.4.16, and the empty baseline correctly removes the three eliminated diagnostics. The gate handles an empty baseline without failing its parsing/ratchet loops. No patch-introduced correctness issues found. The PR description reports the gate, lint, tests, and typecheck passing; I did not rerun them in this read-only review, and Forgejo CI checks were still pending when reviewed.
yuris merged commit f7029f242a into main 2026-09-30 18:10:54 +00:00
yuris deleted branch ci/186-ratchet-biome-gate 2026-09-30 18:10:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/garage!187
No description provided.