yuris/garage
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages 1 Wiki Activity Actions

ci: ratchet biome-gate baseline and update biome.json schema #186

New issue
Closed
opened 2026-09-30 18:04:12 +00:00 by yuris · 0 comments
yuris commented 2026-09-30 18:04:12 +00:00
Owner
Copy link

Problem

Following the fixes in PR #185, useOptionalChain and useTemplate have 0 findings. .forgejo/scripts/biome-gate.sh failed in CI because its built-in ratchet mechanism requires removing eliminated rules from BASELINE. Additionally, biome.json specifies schema 2.2.0 while the environment runs Biome CLI 2.4.16, producing a deserialize diagnostic.

Acceptance Criteria

  • Remove lint/complexity/useOptionalChain and lint/style/useTemplate from BASELINE in .forgejo/scripts/biome-gate.sh.
  • Update $schema in biome.json to 2.4.16 and update BASELINE accordingly.
  • .forgejo/scripts/biome-gate.sh passes cleanly (exit code 0).
  • pnpm lint, pnpm test, and pnpm typecheck continue to pass cleanly.
### Problem Following the fixes in PR #185, `useOptionalChain` and `useTemplate` have 0 findings. `.forgejo/scripts/biome-gate.sh` failed in CI because its built-in ratchet mechanism requires removing eliminated rules from `BASELINE`. Additionally, `biome.json` specifies schema `2.2.0` while the environment runs Biome CLI `2.4.16`, producing a `deserialize` diagnostic. ### Acceptance Criteria - [ ] Remove `lint/complexity/useOptionalChain` and `lint/style/useTemplate` from `BASELINE` in `.forgejo/scripts/biome-gate.sh`. - [ ] Update `$schema` in `biome.json` to `2.4.16` and update `BASELINE` accordingly. - [ ] `.forgejo/scripts/biome-gate.sh` passes cleanly (exit code 0). - [ ] `pnpm lint`, `pnpm test`, and `pnpm typecheck` continue to pass cleanly.
yuris closed this issue 2026-09-30 18:10:55 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feat/remove-supplier-category-and-terms
fix/suppliers-table-single-line
feat/phase-5-batch-price-update
feat/phase-4-supplier-catalog-pricing
feat/phase-3-supplier-directory
feat/phase-2-admin-auth-nav
feat/phase-1-supplier-schema
ci/166-prune-container-images
store/services-order
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/garage#186
No description provided.