yuris/garage
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix(dashboard): refine monthly profit layout and settings nav icon #173

Merged
yuris merged 1 commit from fix/172-dashboard-profit-settings-nav into main 2026-09-30 09:30:48 +00:00
Conversation 1 Commits 1 Files changed 2 +19 -42
yuris commented 2026-09-30 09:25:44 +00:00
Owner
Copy link

Closes #172

What changed

  • In apps/management/app/(dashboard)/page.tsx, kept (Bulan ini) subtitle inline with LABA BERSIH OPERASIONAL on mobile by changing block sm:inline sm:ml-1 to inline ml-1.
  • In apps/management/app/(dashboard)/page.tsx, removed Rata-rata: ... /bln metric and bullet separator from the 6-month profit graphic header, keeping only Total 6 bulan: ....
  • In apps/management/components/dashboard-nav.tsx, switched settings icon to Settings01Icon from @hugeicons/core-free-icons (24px on mobile, 20px on desktop), highlighted it only when route is active under /settings, and removed the custom GearIcon SVG helper.

Verified

  • pnpm --filter garage test: 27 test files, 516 tests passed.
  • pnpm --filter garage typecheck: passed with 0 errors.
  • .forgejo/scripts/biome-gate.sh: passed with 0 errors.

Deviations

None.

Note: Merging to main triggers production deployment via .forgejo/workflows/build-publish.yml.

Closes #172 ### What changed - In `apps/management/app/(dashboard)/page.tsx`, kept `(Bulan ini)` subtitle inline with `LABA BERSIH OPERASIONAL` on mobile by changing `block sm:inline sm:ml-1` to `inline ml-1`. - In `apps/management/app/(dashboard)/page.tsx`, removed `Rata-rata: ... /bln` metric and bullet separator from the 6-month profit graphic header, keeping only `Total 6 bulan: ...`. - In `apps/management/components/dashboard-nav.tsx`, switched settings icon to `Settings01Icon` from `@hugeicons/core-free-icons` (24px on mobile, 20px on desktop), highlighted it only when route is active under `/settings`, and removed the custom `GearIcon` SVG helper. ### Verified - `pnpm --filter garage test`: 27 test files, 516 tests passed. - `pnpm --filter garage typecheck`: passed with 0 errors. - `.forgejo/scripts/biome-gate.sh`: passed with 0 errors. ### Deviations None. > Note: Merging to `main` triggers production deployment via `.forgejo/workflows/build-publish.yml`.
fix(dashboard): refine monthly profit layout and settings nav icon
All checks were successful
Checks / test @garage/catalog (pull_request) Successful in 1m14s
Details
Checks / test garage (pull_request) Successful in 1m27s
Details
Checks / test garage-store (pull_request) Successful in 1m19s
Details
Checks / typecheck apps/management (pull_request) Successful in 1m39s
Details
Checks / lint (biome) (pull_request) Successful in 12s
Details
Checks / typecheck apps/store (pull_request) Successful in 1m22s
Details
3c9705e018
yuris commented 2026-09-30 09:30:35 +00:00
Author
Owner
Copy link

VERDICT: approve

All four acceptance criteria are reflected in the diff; garage tests, management typecheck, and biome gate pass. No issues found.

VERDICT: approve All four acceptance criteria are reflected in the diff; garage tests, management typecheck, and biome gate pass. No issues found.
yuris merged commit 20da0732c3 into main 2026-09-30 09:30:48 +00:00
yuris deleted branch fix/172-dashboard-profit-settings-nav 2026-09-30 09:30:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/garage!173
No description provided.