yuris/garage
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix(dashboard): exclude service items from physical unit calculation (#143) #146

Merged
yuris merged 1 commit from fix/143-exclude-services-from-dashboard-units into main 2026-09-29 11:47:31 +00:00
Conversation 2 Commits 1 Files changed 1 +3 -1
yuris commented 2026-09-29 11:39:06 +00:00
Owner
Copy link

Closes #143.

What changed

  • apps/management/app/(dashboard)/page.tsx: filter out type === "Service" from physicalUnits calculation so service items do not inflate stock counts.

Verified

  • pnpm --dir /home/yuris/Development/webdev/wt-143 verify:management passed.

Deviations

none

Closes #143. ## What changed - `apps/management/app/(dashboard)/page.tsx`: filter out `type === "Service"` from `physicalUnits` calculation so service items do not inflate stock counts. ## Verified - `pnpm --dir /home/yuris/Development/webdev/wt-143 verify:management` passed. ## Deviations none
fix(dashboard): exclude service items from physical unit calculation (#143)
All checks were successful
Checks / test @garage/catalog (pull_request) Successful in 1m16s
Details
Checks / test garage (pull_request) Successful in 1m31s
Details
Checks / test garage-store (pull_request) Successful in 1m22s
Details
Checks / lint (biome) (pull_request) Successful in 12s
Details
Checks / typecheck apps/management (pull_request) Successful in 1m42s
Details
Checks / typecheck apps/store (pull_request) Successful in 1m26s
Details
1a2b248beb
yuris reviewed 2026-09-29 11:40:14 +00:00
yuris left a comment
Copy link

VERDICT: approve

The dashboard physical-unit total now excludes Service rows and includes Part, Consumable, and Accessory stock. SKU count and stock value remain unchanged; the diff contains no unrelated edits. The PR reports verify:management passed; Forgejo CI checks were pending when reviewed, so I did not independently confirm the validation result.

VERDICT: approve The dashboard physical-unit total now excludes Service rows and includes Part, Consumable, and Accessory stock. SKU count and stock value remain unchanged; the diff contains no unrelated edits. The PR reports verify:management passed; Forgejo CI checks were pending when reviewed, so I did not independently confirm the validation result.
yuris commented 2026-09-29 11:47:26 +00:00
Author
Owner
Copy link

Note: Merging this pull request triggers the deployment workflow to main.

Note: Merging this pull request triggers the deployment workflow to main.
yuris merged commit dd9f7d317c into main 2026-09-29 11:47:31 +00:00
yuris deleted branch fix/143-exclude-services-from-dashboard-units 2026-09-29 11:47:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/garage!146
No description provided.