yuris/titik-gambut-next
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

refactor(concessions): delete bespoke tools/rustgis and streamline pmtiles pipeline #90

Merged
yuris merged 1 commit from refactor/remove-redundant-rust-crate into main 2026-10-14 23:19:40 +00:00
Conversation 1 Commits 1 Files changed 10 +131 -574
yuris commented 2026-10-14 23:17:28 +00:00
Owner
Copy link

Eliminates redundant in-house Rust crate, normalizes attributes directly in seed generator, and streams GeoJSON directly to tippecanoe.

  • Completely deleted tools/rustgis and bespoke GeoJSON parsing logic.
  • Standardized attribute normalization in scripts/generate-seed-concessions.py.
  • Streamlined scripts/build-concessions-pmtiles.sh to compile directly with tippecanoe without cargo build steps.
  • Passes all checks: pnpm test (74 tests passed), vp check (0 errors), and next build (clean standalone build).
Eliminates redundant in-house Rust crate, normalizes attributes directly in seed generator, and streams GeoJSON directly to tippecanoe. - Completely deleted `tools/rustgis` and bespoke GeoJSON parsing logic. - Standardized attribute normalization in `scripts/generate-seed-concessions.py`. - Streamlined `scripts/build-concessions-pmtiles.sh` to compile directly with tippecanoe without cargo build steps. - Passes all checks: `pnpm test` (74 tests passed), `vp check` (0 errors), and `next build` (clean standalone build).
refactor(concessions): delete bespoke tools/rustgis and streamline pmtiles pipeline
All checks were successful
CI / Verify Quality & Build (pull_request) Successful in 1m46s
Details
bf9c43999b 
Eliminates redundant in-house Rust crate, normalizes attributes directly in seed generator, and streams GeoJSON directly to tippecanoe.
yuris-bot approved these changes 2026-10-14 23:19:35 +00:00
yuris-bot left a comment
Copy link

Code Review & Ponytail Audit Summary: Delete Bespoke tools/rustgis

1. Ponytail Audit (Anti-Bloat & De-duplication)

  • tools/rustgis: delete: 502-line bespoke Rust crate and manual GeoJSON coordinate parser. Replaced by direct tippecanoe compilation.
  • scripts/install-rustgis.sh: delete: 44-line installation script. Nothing replaces it.
  • scripts/build-concessions-pmtiles.sh: shrink: eliminated cargo build & intermediate cache steps. Direct stream to tippecanoe (-24 lines).
  • net: -443 lines, -1 bespoke crate, 0 new abstractions.

2. Subsystem Boundary & Discipline

  • Confined to backend data/scripts domain. Zero frontend or UI leakage.

3. Verification & Test Proofs

  • vp check: Passed 100% (249 files formatted, 0 warnings/lint errors in 80 files).
  • pnpm test: All 74 tests passed across 11 test suites.
  • next build: Production build succeeded cleanly.
  • CI: CI / Verify Quality & Build (pull_request) succeeded on Forgejo.

Decision: APPROVED for squash merge into main.

### Code Review & Ponytail Audit Summary: Delete Bespoke tools/rustgis #### 1. Ponytail Audit (Anti-Bloat & De-duplication) - **tools/rustgis**: `delete: 502-line bespoke Rust crate and manual GeoJSON coordinate parser. Replaced by direct tippecanoe compilation.` - **scripts/install-rustgis.sh**: `delete: 44-line installation script. Nothing replaces it.` - **scripts/build-concessions-pmtiles.sh**: `shrink: eliminated cargo build & intermediate cache steps. Direct stream to tippecanoe (-24 lines).` - **net**: `-443 lines, -1 bespoke crate, 0 new abstractions.` #### 2. Subsystem Boundary & Discipline - Confined to backend data/scripts domain. Zero frontend or UI leakage. #### 3. Verification & Test Proofs - `vp check`: Passed 100% (249 files formatted, 0 warnings/lint errors in 80 files). - `pnpm test`: All 74 tests passed across 11 test suites. - `next build`: Production build succeeded cleanly. - CI: `CI / Verify Quality & Build (pull_request)` succeeded on Forgejo. **Decision**: APPROVED for squash merge into `main`.
yuris merged commit d76edaf61e into main 2026-10-14 23:19:40 +00:00
yuris deleted branch refactor/remove-redundant-rust-crate 2026-10-14 23:19:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
yuris-bot
Labels
Clear labels   
backend
Backend task

  
frontend
Frontend task

No labels
backend
frontend
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/titik-gambut-next!90
No description provided.