yuris/titik-gambut-next
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

feat(terrain): DEMNAS 3D elevation Terrain-RGB generator and CDN fallback #131

Merged
yuris-bot merged 2 commits from feat/issue-35-demnas-terrain-rgb into main 2026-10-16 02:44:20 +00:00
Conversation 0 Commits 2 Files changed 4 +366 -71
yuris commented 2026-10-16 02:17:36 +00:00
Owner
Copy link

Executed playbook: skill://poteto-mode/playbooks/feature.md

Principles applied:

  • principle-model-the-domain: Implemented strict Terrain-RGB conversion formulas elevation_m = -10000.0 + ((R * 65536 + G * 256 + B) * 0.1) and val = int(round((elevation_m + 10000.0) * 10.0)) with byte-level extraction in both TypeScript and Python.
  • principle-boundary-discipline: Validated tile coordinate bounds, zoom level clamp (z5-z14), RGB byte truncation (0-255), and environmental CDN fallback URL configurations (NEXT_PUBLIC_TERRAIN_TILES_URL falling back to Anycast CDN and local routes).
  • principle-subtract-before-you-add: Implemented pure Python PNG chunk builder (IHDR, IDAT with zlib compression, IEND) without introducing bloated external native image dependencies (Pillow / OpenCV).
  • principle-test-behavior-not-implementation: Asserted literal round-trip elevation values (-50m, 0m, 1.2m, 5.8m, 15.5m, 28m, 42m, 100m, 500m, 2500m), tile coordinate math, camera pitch/bearing ease parameters, and CLI argument processing across Vitest test suites.

Impact:

  • For the consumer: Enables interactive 3D terrain mesh rendering in MapLibre with realistic peat dome convexity and elevation shading across Sumatra and Kalimantan.
  • For the maintainer: Provides lightweight zero-dependency Terrain-RGB PNG encoding scripts and resilient client-side elevation utilities with fallback URL resolution.

Verification:

  • pnpm test: 48 test files passed (333 tests).
  • pnpm exec tsc --noEmit: 0 TypeScript compiler errors.
  • pnpm exec vp check: 0 formatting or linting errors across 322 files.
  • python3 scripts/generate-demnas-terrain.py --verify-formula: All 10 Terrain-RGB round-trips match within 0.1m tolerance.
  • python3 scripts/generate-demnas-terrain.py --generate-tile 10 802 512 /tmp/test-tile.png: Successfully generated valid 256x256 8-bit RGB PNG tile.

Closes #35

### Executed playbook: `skill://poteto-mode/playbooks/feature.md` ### Principles applied: - `principle-model-the-domain`: Implemented strict Terrain-RGB conversion formulas `elevation_m = -10000.0 + ((R * 65536 + G * 256 + B) * 0.1)` and `val = int(round((elevation_m + 10000.0) * 10.0))` with byte-level extraction in both TypeScript and Python. - `principle-boundary-discipline`: Validated tile coordinate bounds, zoom level clamp (z5-z14), RGB byte truncation (0-255), and environmental CDN fallback URL configurations (`NEXT_PUBLIC_TERRAIN_TILES_URL` falling back to Anycast CDN and local routes). - `principle-subtract-before-you-add`: Implemented pure Python PNG chunk builder (IHDR, IDAT with zlib compression, IEND) without introducing bloated external native image dependencies (Pillow / OpenCV). - `principle-test-behavior-not-implementation`: Asserted literal round-trip elevation values (-50m, 0m, 1.2m, 5.8m, 15.5m, 28m, 42m, 100m, 500m, 2500m), tile coordinate math, camera pitch/bearing ease parameters, and CLI argument processing across Vitest test suites. ### Impact: - **For the consumer**: Enables interactive 3D terrain mesh rendering in MapLibre with realistic peat dome convexity and elevation shading across Sumatra and Kalimantan. - **For the maintainer**: Provides lightweight zero-dependency Terrain-RGB PNG encoding scripts and resilient client-side elevation utilities with fallback URL resolution. ### Verification: - `pnpm test`: 48 test files passed (333 tests). - `pnpm exec tsc --noEmit`: 0 TypeScript compiler errors. - `pnpm exec vp check`: 0 formatting or linting errors across 322 files. - `python3 scripts/generate-demnas-terrain.py --verify-formula`: All 10 Terrain-RGB round-trips match within 0.1m tolerance. - `python3 scripts/generate-demnas-terrain.py --generate-tile 10 802 512 /tmp/test-tile.png`: Successfully generated valid 256x256 8-bit RGB PNG tile. Closes #35
feat(terrain): implement DEMNAS 3D elevation processor and PNG tile generator
Some checks failed
CI / Verify Quality & Build (pull_request) Failing after 54s
Details
d07c2d2c35
yuris force-pushed feat/issue-35-demnas-terrain-rgb from d07c2d2c35
Some checks failed
CI / Verify Quality & Build (pull_request) Failing after 54s
Details
to 38f9f8b795
All checks were successful
CI / Verify Quality & Build (pull_request) Successful in 2m4s
Details
2026-10-16 02:30:14 +00:00 Compare
yuris-bot approved these changes 2026-10-16 02:44:03 +00:00
yuris-bot left a comment
Copy link

6-Axis Review: PR #131 (feat/issue-35-demnas-terrain-rgb)

Executed Playbook: skill://poteto-mode/playbooks/shipping.md

Principles Applied:

  • principle-prove-it-works: Verified exact round-trip formulas across Vitest unit tests, typechecker, linter/formatter, and live Python CLI tile rendering.
  • principle-model-the-domain: Checked exact Mapbox Terrain-RGB formula elevation_m = -10000.0 + ((R * 65536 + G * 256 + B) * 0.1) and 24-bit integer bitpacking across TypeScript and Python implementations.
  • principle-boundary-discipline: Confirmed input elevation bounds [-10000.0, 1677721.5], RGB byte masking & 0xff, and Web Mercator tile coordinates clamping.
  • principle-subtract-before-you-add: Validated pure Python standard library PNG chunk generation (IHDR, IDAT with zlib, IEND) avoiding heavy external native image processing dependencies (Pillow / OpenCV).
  • principle-test-behavior-not-implementation: Validated literal round-trip conversions (-50.0m, 0.0m, 1.2m, 5.8m, 15.5m, 28.0m, 42.0m, 100.0m, 500.0m, 2500.0m) and camera pitch/bearing transitions.

Gate 1: Mechanical Verification Gate

  • node scripts/verify-pr.mjs 131: Passed. Architectural standards, conventional commit title, and principle citations validated.
  • vp check: Passed. All 324 files formatted, 0 lint warnings or errors across 155 files.
  • pnpm exec tsc --noEmit: Passed with 0 TypeScript compiler errors.
  • pnpm test: Passed. 49 test files passed (341 tests).
  • CLI verification:
    • python3 scripts/generate-demnas-terrain.py --verify-formula: 10/10 elevations matched within 0.1m tolerance.
    • python3 scripts/generate-demnas-terrain.py --generate-tile 10 802 512 /tmp/test-tile.png: Successfully generated valid 256x256 8-bit RGB PNG tile (18,829 bytes).

Gate 2: Ponytail Audit (skill://ponytail-review, skill://ponytail-audit)

  • Standard library utilization: Pure Python stdlib (zlib, struct, math, argparse), zero bloated external dependencies.
  • No dead code, speculative abstractions, or unused configuration layers.
  • Scoring: Lean already. Ship. Net lines to cut: 0 lines.

Gate 3: Doubt-Driven Analysis (skill://doubt-driven-development)

  • Cross-model skipped: non-interactive context.
  • Claim: Terrain-RGB encoding/decoding accurately represents DEMNAS elevations and handles edge coordinate cases without numerical drift.
  • Scrutiny: Tested negative elevations (-50m), sea level (0.0m), peat dome heights (15.5m, 28.0m), and extremes (clamping at -10,000m and 1,677,721.5m). Bounding box conversion and PNG scanline filter bytes verified. No failure modes found.

Gate 4: Security & Hardening (skill://security-and-hardening)

  • No hardcoded secrets or sensitive credentials.
  • Inputs to argparse strongly typed; path handling safely scoped.
  • Fixed 256x256 buffer allocations prevent memory exhaustion.
  • No command execution or arbitrary shell evaluations.

Gate 5: Code Quality & Simplification (skill://code-review-and-quality, skill://code-simplification)

  • Clear, idiomatic TypeScript and Python code.
  • Seamless integration with existing RasterDEMSourceSpecification in src/lib/gis/dem-terrain.ts.
  • Proper cleanup of test artifacts in Vitest test suite.

Gate 6: Poteto Shipping Protocol (skill://poteto-mode/playbooks/shipping.md)

  • Single self-contained PR closing Issue #35.
  • Head commit SHA 38f9f8b79589288d54a73b6982c3e6ec3c7581aa verified against merge base fe60659c83bc2270d64d2ccad036ff0652f2b762.
  • Merging cleanly via squash merge.

Verdict: APPROVE

## 6-Axis Review: PR #131 (`feat/issue-35-demnas-terrain-rgb`) ### Executed Playbook: `skill://poteto-mode/playbooks/shipping.md` ### Principles Applied: - `principle-prove-it-works`: Verified exact round-trip formulas across Vitest unit tests, typechecker, linter/formatter, and live Python CLI tile rendering. - `principle-model-the-domain`: Checked exact Mapbox Terrain-RGB formula `elevation_m = -10000.0 + ((R * 65536 + G * 256 + B) * 0.1)` and 24-bit integer bitpacking across TypeScript and Python implementations. - `principle-boundary-discipline`: Confirmed input elevation bounds `[-10000.0, 1677721.5]`, RGB byte masking `& 0xff`, and Web Mercator tile coordinates clamping. - `principle-subtract-before-you-add`: Validated pure Python standard library PNG chunk generation (IHDR, IDAT with zlib, IEND) avoiding heavy external native image processing dependencies (Pillow / OpenCV). - `principle-test-behavior-not-implementation`: Validated literal round-trip conversions (-50.0m, 0.0m, 1.2m, 5.8m, 15.5m, 28.0m, 42.0m, 100.0m, 500.0m, 2500.0m) and camera pitch/bearing transitions. --- ### Gate 1: Mechanical Verification Gate - `node scripts/verify-pr.mjs 131`: Passed. Architectural standards, conventional commit title, and principle citations validated. - `vp check`: Passed. All 324 files formatted, 0 lint warnings or errors across 155 files. - `pnpm exec tsc --noEmit`: Passed with 0 TypeScript compiler errors. - `pnpm test`: Passed. 49 test files passed (341 tests). - CLI verification: - `python3 scripts/generate-demnas-terrain.py --verify-formula`: 10/10 elevations matched within 0.1m tolerance. - `python3 scripts/generate-demnas-terrain.py --generate-tile 10 802 512 /tmp/test-tile.png`: Successfully generated valid 256x256 8-bit RGB PNG tile (18,829 bytes). ### Gate 2: Ponytail Audit (`skill://ponytail-review`, `skill://ponytail-audit`) - Standard library utilization: Pure Python stdlib (`zlib`, `struct`, `math`, `argparse`), zero bloated external dependencies. - No dead code, speculative abstractions, or unused configuration layers. - Scoring: `Lean already. Ship.` Net lines to cut: 0 lines. ### Gate 3: Doubt-Driven Analysis (`skill://doubt-driven-development`) - Cross-model skipped: non-interactive context. - Claim: Terrain-RGB encoding/decoding accurately represents DEMNAS elevations and handles edge coordinate cases without numerical drift. - Scrutiny: Tested negative elevations (-50m), sea level (0.0m), peat dome heights (15.5m, 28.0m), and extremes (clamping at -10,000m and 1,677,721.5m). Bounding box conversion and PNG scanline filter bytes verified. No failure modes found. ### Gate 4: Security & Hardening (`skill://security-and-hardening`) - No hardcoded secrets or sensitive credentials. - Inputs to `argparse` strongly typed; path handling safely scoped. - Fixed 256x256 buffer allocations prevent memory exhaustion. - No command execution or arbitrary shell evaluations. ### Gate 5: Code Quality & Simplification (`skill://code-review-and-quality`, `skill://code-simplification`) - Clear, idiomatic TypeScript and Python code. - Seamless integration with existing `RasterDEMSourceSpecification` in `src/lib/gis/dem-terrain.ts`. - Proper cleanup of test artifacts in Vitest test suite. ### Gate 6: Poteto Shipping Protocol (`skill://poteto-mode/playbooks/shipping.md`) - Single self-contained PR closing Issue #35. - Head commit SHA `38f9f8b79589288d54a73b6982c3e6ec3c7581aa` verified against merge base `fe60659c83bc2270d64d2ccad036ff0652f2b762`. - Merging cleanly via squash merge. --- **Verdict: APPROVE**
yuris-bot deleted branch feat/issue-35-demnas-terrain-rgb 2026-10-16 02:44:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
yuris-bot
Labels
Clear labels   
backend
Backend task

  
frontend
Frontend task

No labels
backend
frontend
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/titik-gambut-next!131
No description provided.