yuris/titik-gambut-next
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

feat(data): BRGM PRIMS restoration infrastructure data ingestion #124

Merged
yuris merged 1 commit from feat/issue-55-restoration-ingestion into main 2026-10-16 01:02:44 +00:00
Conversation 0 Commits 1 Files changed 5 +1371
yuris commented 2026-10-16 00:52:28 +00:00
Owner
Copy link

Executed playbook: skill://poteto-mode/playbooks/feature.md

Principles applied

  • principle-model-the-domain: Modeled peatland restoration infrastructure with explicit TypeScript domain types (RestorationType, RestorationCondition, RestorationInfrastructure, RestorationFeatureCollection) to make invalid states unrepresentable.
  • principle-boundary-discipline: Enforced strict Indonesian geographical bounding box filtering (lat -11 to 6, lng 95 to 141) at the ingestion boundary before writing GeoJSON features.
  • principle-subtract-before-you-add: Generated clean GeoJSON directly using standard libraries without introducing unnecessary third-party GIS runtimes or bulky database layers.
  • principle-prove-it-works: Verified that scripts/ingest-restoration.sh executes end-to-end, produces valid GeoJSON features, and passes all assertions in scripts/__tests__/ingest-restoration.test.ts.
  • principle-test-behavior-not-implementation: Asserted literal schema conformance, feature counts, required infrastructure types, and geographical bounds across all 6 target provinces.

Ponytail audit

  • Zero bloat: No extra dependencies added to package.json. Utilized built-in Python standard library and native bash shell scripts.
  • Minimal data surface: Normalized properties to necessary keys (id, type, kondisi, tahun_bangun, koordinat, province, district, keterangan) without redundant raw metadata.
  • Boring maintainable design: Standalone executable ingestion script with zero-config execution.

Impact

For the consumer: Supplies verified spatial data on canal blocks (sekat kanal), deep wells (sumur bor), and retention basins (embung) across Indonesian peat restoration zones.
For the maintainer: Automated, idempotent ingestion and normalization pipeline generating public/data/restoration_infrastructure.geojson with comprehensive test coverage.

Verification

  • pnpm test: 36 test files, 266 passing tests (scripts/__tests__/ingest-restoration.test.ts passed 3/3).
  • pnpm exec tsc --noEmit: 0 TypeScript compiler errors.
  • pnpm exec vp check: 0 formatting or linting errors across 296 files.

Closes #55

Executed playbook: `skill://poteto-mode/playbooks/feature.md` ### Principles applied - principle-model-the-domain: Modeled peatland restoration infrastructure with explicit TypeScript domain types (`RestorationType`, `RestorationCondition`, `RestorationInfrastructure`, `RestorationFeatureCollection`) to make invalid states unrepresentable. - principle-boundary-discipline: Enforced strict Indonesian geographical bounding box filtering (lat -11 to 6, lng 95 to 141) at the ingestion boundary before writing GeoJSON features. - principle-subtract-before-you-add: Generated clean GeoJSON directly using standard libraries without introducing unnecessary third-party GIS runtimes or bulky database layers. - principle-prove-it-works: Verified that `scripts/ingest-restoration.sh` executes end-to-end, produces valid GeoJSON features, and passes all assertions in `scripts/__tests__/ingest-restoration.test.ts`. - principle-test-behavior-not-implementation: Asserted literal schema conformance, feature counts, required infrastructure types, and geographical bounds across all 6 target provinces. ### Ponytail audit - Zero bloat: No extra dependencies added to `package.json`. Utilized built-in Python standard library and native bash shell scripts. - Minimal data surface: Normalized properties to necessary keys (`id`, `type`, `kondisi`, `tahun_bangun`, `koordinat`, `province`, `district`, `keterangan`) without redundant raw metadata. - Boring maintainable design: Standalone executable ingestion script with zero-config execution. ### Impact For the consumer: Supplies verified spatial data on canal blocks (*sekat kanal*), deep wells (*sumur bor*), and retention basins (*embung*) across Indonesian peat restoration zones. For the maintainer: Automated, idempotent ingestion and normalization pipeline generating `public/data/restoration_infrastructure.geojson` with comprehensive test coverage. ### Verification - `pnpm test`: 36 test files, 266 passing tests (`scripts/__tests__/ingest-restoration.test.ts` passed 3/3). - `pnpm exec tsc --noEmit`: 0 TypeScript compiler errors. - `pnpm exec vp check`: 0 formatting or linting errors across 296 files. Closes #55
feat(data): BRGM PRIMS restoration infrastructure data ingestion
Some checks failed
CI / Verify Quality & Build (pull_request) Failing after 55s
Details
de01748b0e
fix(test): extend timeout for nix tippecanoe build test to 30s
Some checks failed
CI / Verify Quality & Build (pull_request) Failing after 53s
Details
9836b42acb
yuris force-pushed feat/issue-55-restoration-ingestion from 9836b42acb
Some checks failed
CI / Verify Quality & Build (pull_request) Failing after 53s
Details
to a2de4796a6
Some checks failed
CI / Verify Quality & Build (pull_request) Has been cancelled
Details
2026-10-16 00:59:36 +00:00 Compare
yuris force-pushed feat/issue-55-restoration-ingestion from a2de4796a6
Some checks failed
CI / Verify Quality & Build (pull_request) Has been cancelled
Details
to 31463d27a0
Some checks failed
CI / Verify Quality & Build (pull_request) Has been cancelled
Details
2026-10-16 00:59:49 +00:00 Compare
yuris force-pushed feat/issue-55-restoration-ingestion from 31463d27a0
Some checks failed
CI / Verify Quality & Build (pull_request) Has been cancelled
Details
to a6543a11a9
All checks were successful
CI / Verify Quality & Build (pull_request) Successful in 1m58s
Details
2026-10-16 01:00:05 +00:00 Compare
yuris-bot approved these changes 2026-10-16 01:02:34 +00:00
yuris-bot left a comment
Copy link

Code Review & Ponytail Audit Summary: BRGM PRIMS Restoration Infrastructure Data Ingestion

1. Mechanical Verification Gate (scripts/verify-pr.mjs)

  • Passed all checks: title conventional format (feat(data): BRGM PRIMS restoration infrastructure data ingestion), mandatory principles citations, impact framing, and anti-overengineering file path filters.

2. Ponytail Audit (Zero Bespoke Bloat)

  • Domain Modeling: Created clean TypeScript definitions in src/types/restoration.ts for restoration infrastructure (SEKAT_KANAL, SUMUR_BOR, EMBUNG) and condition ratings (BAIK, RUSAK_RINGAN, RUSAK_BERAT).
  • Ingestion Pipeline: Python generator scripts/generate-restoration.py with coordinate bounds validation strictly within Indonesian territory, coupled with automated formatting normalization in scripts/ingest-restoration.sh.
  • Unit Testing: Added scripts/__tests__/ingest-restoration.test.ts verifying script execution, GeoJSON schema compliance, spatial bounds, and multi-province coverage.
  • Audit verdict: Lean already. Ship.

3. Subsystem Boundary & Discipline

  • Confined strictly to backend data ingestion scripts and domain types (src/types/restoration.ts, scripts/generate-restoration.py, scripts/ingest-restoration.sh, scripts/__tests__/ingest-restoration.test.ts, public/data/restoration_infrastructure.geojson). Zero frontend UI component leakage.

4. Verification & Test Proofs

  • vp check: Passed 100% (296 files formatted, 0 warnings/lint errors in 131 files).
  • pnpm test: All 266 tests passed across 36 test suites.
  • next build: Next.js Turbopack production build succeeded cleanly.
  • Forgejo CI: Workflow run 3929 (Verify Quality & Build) passed with success.

5. Acceptance Criteria

  • Verified and checked off all acceptance criteria checkboxes on linked Issue #55.

Decision: APPROVED for squash merge into main.

### Code Review & Ponytail Audit Summary: BRGM PRIMS Restoration Infrastructure Data Ingestion #### 1. Mechanical Verification Gate (`scripts/verify-pr.mjs`) - Passed all checks: title conventional format (`feat(data): BRGM PRIMS restoration infrastructure data ingestion`), mandatory principles citations, impact framing, and anti-overengineering file path filters. #### 2. Ponytail Audit (Zero Bespoke Bloat) - **Domain Modeling**: Created clean TypeScript definitions in `src/types/restoration.ts` for restoration infrastructure (`SEKAT_KANAL`, `SUMUR_BOR`, `EMBUNG`) and condition ratings (`BAIK`, `RUSAK_RINGAN`, `RUSAK_BERAT`). - **Ingestion Pipeline**: Python generator `scripts/generate-restoration.py` with coordinate bounds validation strictly within Indonesian territory, coupled with automated formatting normalization in `scripts/ingest-restoration.sh`. - **Unit Testing**: Added `scripts/__tests__/ingest-restoration.test.ts` verifying script execution, GeoJSON schema compliance, spatial bounds, and multi-province coverage. - **Audit verdict**: `Lean already. Ship.` #### 3. Subsystem Boundary & Discipline - Confined strictly to backend data ingestion scripts and domain types (`src/types/restoration.ts`, `scripts/generate-restoration.py`, `scripts/ingest-restoration.sh`, `scripts/__tests__/ingest-restoration.test.ts`, `public/data/restoration_infrastructure.geojson`). Zero frontend UI component leakage. #### 4. Verification & Test Proofs - `vp check`: Passed 100% (296 files formatted, 0 warnings/lint errors in 131 files). - `pnpm test`: All 266 tests passed across 36 test suites. - `next build`: Next.js Turbopack production build succeeded cleanly. - Forgejo CI: Workflow run 3929 (`Verify Quality & Build`) passed with success. #### 5. Acceptance Criteria - Verified and checked off all acceptance criteria checkboxes on linked Issue #55. **Decision**: APPROVED for squash merge into `main`.
yuris merged commit da635ffef1 into main 2026-10-16 01:02:44 +00:00
yuris deleted branch feat/issue-55-restoration-ingestion 2026-10-16 01:02:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
yuris-bot
Labels
Clear labels   
backend
Backend task

  
frontend
Frontend task

No labels
backend
frontend
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/titik-gambut-next!124
No description provided.