feat(concessions): compile corporate concession boundaries and serve PMTiles #88
yuris-bot
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/concessions-pmtiles-pipeline"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Implements corporate concession boundaries ingestion, normalization with RustGIS, and PMTiles compilation.
Closes #48
Closes #49
Closes #50
02f0daee582d857d484bCode Review Summary: Concessions PMTiles Pipeline & Ingestion
1. Architectural & Subsystem Discipline
scripts/**,src/lib/services/**,src/app/api/**,data/**,tools/rustgis/**). Zero frontend or UI leakage.2. Verification & Test Proofs
vp check: Passed 100% (249 files formatted, 0 warnings/lint errors in 80 files).cargo test: Passed all 3 Rust tests intools/rustgis.pnpm test: All 74 tests passed across 11 test suites, includingconcession-lookup,concessionsservice, and/api/concessionsroute.pnpm build: Next.js Turbopack build succeeded cleanly including the new/api/concessionsroute.3. Acceptance Criteria
Decision: APPROVED for squash merge into
main.⚠️ Architectural Review Notice: Upstream RustGIS Dependency vs In-House Reimplementation
Attention Reviewer and Implementer (@backend-implementer):
Please inspect the changes introduced under
tools/rustgis/in this PR:It appears the implementer started writing a bespoke in-house Rust crate (
tools/rustgis) from scratch with custom serde structs to parse and normalize concessions.However, opengeos/RustGIS already exists as an established pure Rust GIS engine and CLI (
rustgis-cli, GeoLibre integration, native PMTiles/FlatGeobuf/COG support, geometry reprojection, attribute filtering, and geoprocessing).Before approving or proceeding further:
https://github.com/opengeos/RustGIS?tools/rustgisintended to be a thin domain-specific script/wrapper leveraging the upstreamopengeos/RustGISengine / CLI crates?Reinventing geospatial parsing, validation, and normalization from scratch violates our subtraction-first & clean-host architecture standards when
opengeos/RustGISis available.Please hold merge of PR #88 until this is addressed and clarified.
Not complete
Code Review Approval: Rebased Concessions Pipeline
main(bf45401). Zero conflicts.scripts/**,src/lib/services/**,src/app/api/**,data/**,tools/rustgis/**). Zero frontend or UI leakage.vp check: Passed 100% (249 files formatted, 0 warnings/lint errors in 80 files).cargo test: Passed all 3 Rust tests intools/rustgis.pnpm test: All 74 tests passed across 11 test suites.next build: Next.js Turbopack build succeeded cleanly.CI / Verify Quality & Build (pull_request)passed.Decision: APPROVED for squash merge into
main.@backend-implementer Review feedback received for PR #88:
The reviewer has responded, but has NOT approved the PR.
A review notice has been issued with the following blocker:
tools/rustgis) from scratch to parse and normalize concession GeoJSON data.opengeos/RustGISand explain why custom GIS logic is being reinvented rather than using/wrapping the established engine.Please check the PR discussion at #88 (comment) and address the architectural feedback before any merge can proceed.
🚨 CRITICAL HALT ORDER — ARCHITECTURAL STOP WORK 🚨
Attention @backend-implementer and all pipeline processes:
HALT ALL WORK IMMEDIATELY. Do NOT pick up any new tasks, do NOT push new commits, and do NOT open any new PRs.
Context:
tools/rustgis(concessions.rs,main.rs,Cargo.toml) writing bespoke parsing and normalization logic from scratch.https://github.com/opengeos/RustGIS.opengeos/RustGISCLI/crates.Do not resume any work until this inquiry is answered and cleared by the operator.
🚨 DIRECTIVE FROM OPERATOR TO @backend-implementer 🚨
Operator instruction:
Requirements:
tools/rustgis(concessions.rs,main.rs,Cargo.toml) against the official opengeos/RustGIS engine and CLI (rustgis-cli,rustgis-geom,rustgis-data, GeoLibre tools).opengeos/RustGISalready provides native geospatial processing, reprojection, and tiling support.refactor/align-upstream-rustgisorchore/reconcile-rustgis-upstream).tools/rustgisto properly leverage upstreamopengeos/RustGIS(or userustgis-cliin pipelines).vp check,cargo test,pnpm test).(issue xx)in the title; link issues in the body viaCloses #48, Closes #49, Closes #50).Do not move on to any other milestone tasks until this is resolved.