fix(dashboard): exclude services from modal tertahan table and calculations #191

Merged

yuris merged 2 commits from fix/190-exclude-services-modal-tertahan into main 2026-10-02 10:18:45 +00:00

Conversation 3 Commits 2 Files changed 4 +133 -12

yuris commented 2026-10-02 10:09:44 +00:00

Owner

Copy link

Closes #190.

What changed

• apps/management/lib/inventory/queries.ts: Exclude services (type != 'Service') from agedQty, agedCostValue, oldestAgedDate, agedDays, and totalCostValue in getDashboardInventory.
• apps/management/app/(dashboard)/page.tsx: Filter type !== 'Service' in stockValue, agedItems, agedTotalValue, agedSkuCount, and agedPercent.
• apps/management/app/(dashboard)/aging-inventory-table.tsx: Filter type !== 'Service' from initialData in AgingInventoryTable.

Verified

• pnpm verify:management passed (vitest 531 tests, tsc, biome lint).

Deviations

none

Closes #190. ## What changed - `apps/management/lib/inventory/queries.ts`: Exclude services (`type != 'Service'`) from `agedQty`, `agedCostValue`, `oldestAgedDate`, `agedDays`, and `totalCostValue` in `getDashboardInventory`. - `apps/management/app/(dashboard)/page.tsx`: Filter `type !== 'Service'` in `stockValue`, `agedItems`, `agedTotalValue`, `agedSkuCount`, and `agedPercent`. - `apps/management/app/(dashboard)/aging-inventory-table.tsx`: Filter `type !== 'Service'` from `initialData` in `AgingInventoryTable`. ## Verified - `pnpm verify:management` passed (vitest 531 tests, tsc, biome lint). ## Deviations none

yuris added 1 commit 2026-10-02 10:09:44 +00:00

fix(dashboard): exclude services from modal tertahan table and calculations b54dba9206

yuris reviewed 2026-10-02 10:12:26 +00:00

yuris left a comment

Copy link

VERDICT: request-changes

[P2] Include null-typed inventory in physical stock aggregates (apps/management/lib/inventory/queries.ts:239-257). inventory.type is nullable, and the page/table explicitly include every type other than Service. PostgreSQL evaluates NULL != 'Service' as unknown, so the new SQL filters erase the cost and aging values of valid null-typed items with lots. These physical items vanish from Modal Mengendap and their stock value is understated. Use IS DISTINCT FROM 'Service' in each aggregate filter (and cover a null-typed row in a behavior test).

The page KPI and table filters otherwise meet the requested service exclusion. The added test checks generated SQL text using mocked rows rather than executing aggregates, so it misses this mismatch. Forgejo reports the management test job passing; management typecheck and Biome lint were pending at review time. I did not run pnpm verify:management in this read-only review.

VERDICT: request-changes [P2] Include null-typed inventory in physical stock aggregates (`apps/management/lib/inventory/queries.ts:239-257`). `inventory.type` is nullable, and the page/table explicitly include every type other than `Service`. PostgreSQL evaluates `NULL != 'Service'` as unknown, so the new SQL filters erase the cost and aging values of valid null-typed items with lots. These physical items vanish from Modal Mengendap and their stock value is understated. Use `IS DISTINCT FROM 'Service'` in each aggregate filter (and cover a null-typed row in a behavior test). The page KPI and table filters otherwise meet the requested service exclusion. The added test checks generated SQL text using mocked rows rather than executing aggregates, so it misses this mismatch. Forgejo reports the management test job passing; management typecheck and Biome lint were pending at review time. I did not run `pnpm verify:management` in this read-only review.

yuris added 1 commit 2026-10-02 10:14:31 +00:00

fix(dashboard): use is distinct from for service exclusion in inventory queries cf8ec0d33b

yuris commented 2026-10-02 10:14:34 +00:00

Author

Owner

Copy link

Round 1 addressed

• Switched service exclusion in getDashboardInventory SQL query filters to use is distinct from 'Service' instead of != 'Service' across totalCostValue, agedQty, agedCostValue, oldestAgedDate, and agedDays to correctly retain null-typed physical inventory items.
• Updated queries.test.ts to assert is distinct from 'Service' on all aggregate projections and added test coverage for null-typed inventory items.
• Verified with pnpm verify:management (all 532 tests pass, typecheck clean, biome lint clean).

### Round 1 addressed - Switched service exclusion in `getDashboardInventory` SQL query filters to use `is distinct from 'Service'` instead of `!= 'Service'` across `totalCostValue`, `agedQty`, `agedCostValue`, `oldestAgedDate`, and `agedDays` to correctly retain null-typed physical inventory items. - Updated `queries.test.ts` to assert `is distinct from 'Service'` on all aggregate projections and added test coverage for null-typed inventory items. - Verified with `pnpm verify:management` (all 532 tests pass, typecheck clean, biome lint clean).

yuris reviewed 2026-10-02 10:16:38 +00:00

yuris left a comment

Copy link

VERDICT: approve-with-nits
Round 2: The nullable-type finding is resolved. The dashboard query now uses IS DISTINCT FROM for all four aging aggregates and totalCostValue, retaining null-typed physical inventory while zeroing service valuations. The page excludes services from aging KPIs and stockValue; the table excludes service rows. No correctness blockers found.
Nit: The new tests assert SQL fragments and feed precomputed Service/null rows through a mocked DB; they do not execute the query against mixed-type lots, so the Service/null behavioral cases are not actually exercised.
Verification: I did not run pnpm verify:management in this read-only review; its result is not confirmed here.

VERDICT: approve-with-nits Round 2: The nullable-type finding is resolved. The dashboard query now uses IS DISTINCT FROM for all four aging aggregates and totalCostValue, retaining null-typed physical inventory while zeroing service valuations. The page excludes services from aging KPIs and stockValue; the table excludes service rows. No correctness blockers found. Nit: The new tests assert SQL fragments and feed precomputed Service/null rows through a mocked DB; they do not execute the query against mixed-type lots, so the Service/null behavioral cases are not actually exercised. Verification: I did not run pnpm verify:management in this read-only review; its result is not confirmed here.

yuris merged commit dbf949c436 into main 2026-10-02 10:18:45 +00:00

yuris deleted branch fix/190-exclude-services-modal-tertahan 2026-10-02 10:18:45 +00:00

yuris referenced this pull request from a commit 2026-10-02 10:18:46 +00:00

fix(dashboard): exclude services from modal tertahan table and calculations (#191)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

yuris/garage!191

No description provided.