feat(management): paginate aging inventory table and clean mobile stock card layout #189

Merged

yuris merged 2 commits from feat/188-paginate-aging-table into main 2026-10-01 17:04:34 +00:00

Conversation 3 Commits 2 Files changed 4 +262 -132

yuris commented 2026-10-01 16:49:23 +00:00

Owner

Copy link

Closes #188.

What changed

• Created client component AgingInventoryTable using DataTable with client pagination initialized to 5 items per page (pageSize: 5) and page size options (5, 10, 25, 50).
• Swapped static 5-item slice in dashboard page for AgingInventoryTable passing all aged inventory items.
• Added responsive mobile card view for aging inventory table.
• Removed distracting border separator between category and prices in InventoryMobileCard.

Verified

• pnpm --filter garage test passed (all tests green).
• pnpm exec tsc --noEmit passed with 0 errors.
• .forgejo/scripts/biome-gate.sh passed with 0 findings.

Deviations

none

Closes #188. ## What changed - Created client component `AgingInventoryTable` using `DataTable` with client pagination initialized to 5 items per page (`pageSize: 5`) and page size options (5, 10, 25, 50). - Swapped static 5-item slice in dashboard page for `AgingInventoryTable` passing all aged inventory items. - Added responsive mobile card view for aging inventory table. - Removed distracting border separator between category and prices in `InventoryMobileCard`. ## Verified - `pnpm --filter garage test` passed (all tests green). - `pnpm exec tsc --noEmit` passed with 0 errors. - `.forgejo/scripts/biome-gate.sh` passed with 0 findings. ## Deviations none

yuris added 1 commit 2026-10-01 16:49:23 +00:00

feat(management): paginate aging inventory table and clean mobile stock card layout 683d3ad9c3

yuris reviewed 2026-10-01 16:56:55 +00:00

yuris left a comment

Copy link

VERDICT: request-changes

apps/management/app/(dashboard)/aging-inventory-table.tsx:L200-L202: should: The new table initializes at 5 rows, but DataTable derives the page-size dropdown from [pageSize, 10, 25, 50]. After changing to 10, 25, or 50, the 5 option disappears; users cannot return to five per page without reloading. Include 5 permanently in the shared DataTable options (for example, [5, pageSize, 10, 25, 50]).

Verified from the PR diff: all aged rows are passed in cost-descending order, DataTable paginates and renders both desktop and mobile rows, and the inventory mobile-card separator is removed. The 5/10/25/50 acceptance criterion remains unmet after changing page size. At review time CI checks for store tests, both typechecks, and biome lint are pending; please confirm all checks are green before merging.

VERDICT: request-changes apps/management/app/(dashboard)/aging-inventory-table.tsx:L200-L202: should: The new table initializes at 5 rows, but DataTable derives the page-size dropdown from [pageSize, 10, 25, 50]. After changing to 10, 25, or 50, the 5 option disappears; users cannot return to five per page without reloading. Include 5 permanently in the shared DataTable options (for example, [5, pageSize, 10, 25, 50]). Verified from the PR diff: all aged rows are passed in cost-descending order, DataTable paginates and renders both desktop and mobile rows, and the inventory mobile-card separator is removed. The 5/10/25/50 acceptance criterion remains unmet after changing page size. At review time CI checks for store tests, both typechecks, and biome lint are pending; please confirm all checks are green before merging.

yuris added 1 commit 2026-10-01 16:58:52 +00:00

fix(management): ensure page size 5 remains selectable in data table 37209bf216

yuris commented 2026-10-01 16:58:56 +00:00

Author

Owner

Copy link

Round 1 addressed

• Updated DataTable in components/ui/data-table.tsx so 5 is permanently retained in the default page size options ([5, pageSize, 10, 25, 50]), preventing the 5-item option from disappearing when switching to 10, 25, or 50.
• Added optional pageSizeOptions?: number[] prop to DataTableProps and explicitly passed pageSizeOptions={[5, 10, 25, 50]} in AgingInventoryTable.
• Re-verified all tests (pnpm --filter garage test), typecheck (pnpm exec tsc --noEmit), and biome lint gate (.forgejo/scripts/biome-gate.sh), all passing cleanly with 0 errors/findings.

### Round 1 addressed - Updated `DataTable` in `components/ui/data-table.tsx` so `5` is permanently retained in the default page size options (`[5, pageSize, 10, 25, 50]`), preventing the 5-item option from disappearing when switching to 10, 25, or 50. - Added optional `pageSizeOptions?: number[]` prop to `DataTableProps` and explicitly passed `pageSizeOptions={[5, 10, 25, 50]}` in `AgingInventoryTable`. - Re-verified all tests (`pnpm --filter garage test`), typecheck (`pnpm exec tsc --noEmit`), and biome lint gate (`.forgejo/scripts/biome-gate.sh`), all passing cleanly with 0 errors/findings.

yuris reviewed 2026-10-01 17:03:26 +00:00

yuris left a comment

Copy link

VERDICT: approve

Reviewed the complete PR diff at 37209bf: the dashboard now passes every aged inventory item in descending aged-cost order to a TanStack-powered DataTable, with five rows initially, persistent 5/10/25/50 page-size choices, mobile cards and a desktop table. The stock mobile-card separator is removed. The prior round-1 page-size concern is resolved. All six Forgejo checks passed for this exact head: tests for garage, garage-store, and @garage/catalog; management and store typechecks; and the Biome lint gate.

VERDICT: approve Reviewed the complete PR diff at 37209bf: the dashboard now passes every aged inventory item in descending aged-cost order to a TanStack-powered DataTable, with five rows initially, persistent 5/10/25/50 page-size choices, mobile cards and a desktop table. The stock mobile-card separator is removed. The prior round-1 page-size concern is resolved. All six Forgejo checks passed for this exact head: tests for garage, garage-store, and @garage/catalog; management and store typechecks; and the Biome lint gate.

yuris merged commit 36b1a09082 into main 2026-10-01 17:04:34 +00:00

yuris deleted branch feat/188-paginate-aging-table 2026-10-01 17:04:34 +00:00

yuris referenced this pull request from a commit 2026-10-01 17:04:35 +00:00

feat(management): paginate aging inventory table and clean mobile stock card layout (#189)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

yuris/garage!189

No description provided.