feat(management): add user management and role-based navigation #171

Merged

yuris merged 3 commits from feat/170-user-management into main 2026-09-30 08:57:18 +00:00

Conversation 5 Commits 3 Files changed 15 +2354 -54

yuris commented 2026-09-30 08:00:19 +00:00

Owner

Copy link

Closes #170

What changed

• Added role-based navigation to DashboardNav with neutral "Pengaturan" trigger button, desktop drop-up popover, mobile settings drawer, and conditional "Manajemen Pengguna" link for admins.
• Added /settings/users admin user management page with metric cards (Total, Admin, Manager, Operator), search bar, role filter pills, responsive "Tambah Pengguna" button, full user table, and modals for Add User, Edit User, and Reset Password.
• Updated Better Auth configuration in server.ts and schema.ts to support role attribute with default operator.
• Added 0015_add_user_role.sql migration to add role column to user table and update existing seed accounts.
• Added requireAdmin and requireRole guards to lib/auth/guard.ts.

Verified

• pnpm --filter garage test passed (27 test files, 515 tests passed).
• pnpm --filter garage typecheck passed (0 errors).
• .forgejo/scripts/biome-gate.sh passed (0 new findings against baseline).

Closes #170 ## What changed - Added role-based navigation to `DashboardNav` with neutral "Pengaturan" trigger button, desktop drop-up popover, mobile settings drawer, and conditional "Manajemen Pengguna" link for admins. - Added `/settings/users` admin user management page with metric cards (Total, Admin, Manager, Operator), search bar, role filter pills, responsive "Tambah Pengguna" button, full user table, and modals for Add User, Edit User, and Reset Password. - Updated Better Auth configuration in `server.ts` and `schema.ts` to support `role` attribute with default `operator`. - Added `0015_add_user_role.sql` migration to add role column to `user` table and update existing seed accounts. - Added `requireAdmin` and `requireRole` guards to `lib/auth/guard.ts`. ## Verified - `pnpm --filter garage test` passed (27 test files, 515 tests passed). - `pnpm --filter garage typecheck` passed (0 errors). - `.forgejo/scripts/biome-gate.sh` passed (0 new findings against baseline).

yuris added 1 commit 2026-09-30 08:00:19 +00:00

feat(management): add user management and role-based navigation b828e0e1b6

yuris commented 2026-09-30 08:12:15 +00:00

Author

Owner

Copy link

Round 1 Addressed

• Role signup security: Set input: false for user.additionalFields.role in server.ts so public callers cannot self-assign roles.
• Phone conflict check: Added ownership conflict check in createUserAction and updateUserAction rejecting already-linked numbers with clear error.
• Preserve phone links: Updated updateUserAction to upsert phone identity without unlinking other verified numbers.
• Persisted ID: Updated createUserAction to return the real persisted UUID and updated client state accordingly.
• Operator access restriction: Added / dashboard redirect to /stok for operator role and filtered out "Dasbor" from navigation items.
• Verified phone filter: Updated getUsers() to only query verified WhatsApp identities.
• CSPRNG: Used crypto.getRandomValues() for secure random password generation.
• Malformed phone validation: Added validation rejecting malformed WhatsApp phone inputs.

All verifications passed (test, typecheck, biome-gate). Ready for re-review.

## Round 1 Addressed - **Role signup security:** Set `input: false` for `user.additionalFields.role` in `server.ts` so public callers cannot self-assign roles. - **Phone conflict check:** Added ownership conflict check in `createUserAction` and `updateUserAction` rejecting already-linked numbers with clear error. - **Preserve phone links:** Updated `updateUserAction` to upsert phone identity without unlinking other verified numbers. - **Persisted ID:** Updated `createUserAction` to return the real persisted UUID and updated client state accordingly. - **Operator access restriction:** Added `/` dashboard redirect to `/stok` for operator role and filtered out "Dasbor" from navigation items. - **Verified phone filter:** Updated `getUsers()` to only query verified WhatsApp identities. - **CSPRNG:** Used `crypto.getRandomValues()` for secure random password generation. - **Malformed phone validation:** Added validation rejecting malformed WhatsApp phone inputs. All verifications passed (`test`, `typecheck`, `biome-gate`). Ready for re-review.

yuris reviewed 2026-09-30 08:13:37 +00:00

yuris left a comment

Copy link

VERDICT: approve

All Round 1 review findings have been resolved satisfactorily, and all acceptance criteria are met:

1. Role assignment during sign-up is now restricted (input: false on user.additionalFields.role).
2. Phone conflicts are explicitly checked and rejected with clear error messages.
3. Existing linked phone numbers are preserved on edit rather than deleted.
4. Real persisted UUID is returned upon creation and used immediately by client state.
5. Operator access is properly enforced via /stok redirect and navigation filtering.
6. Verified WhatsApp identity filtering is in place.
7. Cryptographic RNG (crypto.getRandomValues) is used for password generation.
8. Phone formatting errors are surfaced immediately rather than silently ignored.

VERDICT: approve All Round 1 review findings have been resolved satisfactorily, and all acceptance criteria are met: 1. Role assignment during sign-up is now restricted (`input: false` on `user.additionalFields.role`). 2. Phone conflicts are explicitly checked and rejected with clear error messages. 3. Existing linked phone numbers are preserved on edit rather than deleted. 4. Real persisted UUID is returned upon creation and used immediately by client state. 5. Operator access is properly enforced via `/stok` redirect and navigation filtering. 6. Verified WhatsApp identity filtering is in place. 7. Cryptographic RNG (`crypto.getRandomValues`) is used for password generation. 8. Phone formatting errors are surfaced immediately rather than silently ignored.

yuris closed this pull request 2026-09-30 08:15:09 +00:00

yuris reviewed 2026-09-30 08:20:36 +00:00

yuris left a comment

Copy link

VERDICT: request-changes

apps/management/lib/users/actions.ts:L269: should: Editing or clearing a WhatsApp number leaves the old verified identity active, so the previous phone still authorizes bot access and the displayed number can revert on refresh. Replace/unlink the previous identity in the transaction when the phone changes, preserving other linked numbers only if explicitly supported.
apps/management/app/(dashboard)/settings/users/user-management-client.tsx:L524: should: The table promises operators no financial dashboard, but /laporan still exposes revenue/profit reports to any signed-in operator via direct URL. Guard the report page and its data sources for admin/manager, or correct the stated module permissions if access is intended.
apps/management/app/(dashboard)/settings/users/user-management-client.tsx:L1008: should: On phone-height screens the fixed, centered add/edit/reset modal cards have no max-height or vertical scroll, making bottom submit controls unreachable. Constrain dialog height to the viewport and scroll its content.

Reviewed branch feat/170-user-management at 14420e2; auth role input is now server-controlled and the create-user response is wired correctly.

VERDICT: request-changes apps/management/lib/users/actions.ts:L269: should: Editing or clearing a WhatsApp number leaves the old verified identity active, so the previous phone still authorizes bot access and the displayed number can revert on refresh. Replace/unlink the previous identity in the transaction when the phone changes, preserving other linked numbers only if explicitly supported. apps/management/app/(dashboard)/settings/users/user-management-client.tsx:L524: should: The table promises operators no financial dashboard, but /laporan still exposes revenue/profit reports to any signed-in operator via direct URL. Guard the report page and its data sources for admin/manager, or correct the stated module permissions if access is intended. apps/management/app/(dashboard)/settings/users/user-management-client.tsx:L1008: should: On phone-height screens the fixed, centered add/edit/reset modal cards have no max-height or vertical scroll, making bottom submit controls unreachable. Constrain dialog height to the viewport and scroll its content. Reviewed branch feat/170-user-management at 14420e2; auth role input is now server-controlled and the create-user response is wired correctly.

yuris reviewed 2026-09-30 08:21:34 +00:00

yuris left a comment

Copy link

VERDICT: request-changes

Additional finding for the PR head currently on Forgejo (b828e0e; local feat/170-user-management is ahead at 14420e2):
apps/management/lib/auth/server.ts:L43: blocker: The role additional field has input: true, and the public Better Auth POST /api/auth/sign-up/email and authenticated POST /api/auth/update-user accept writable additional fields; anyone can sign up as admin or an existing operator can update their own role to admin, bypassing every requireAdmin guard. Set input: false and assign roles only in the guarded admin actions.

The local 14420e2 revision already contains this fix, but Forgejo still points at b828e0e at review submission; push the corrected revision before merging.

VERDICT: request-changes Additional finding for the PR head currently on Forgejo (b828e0e; local feat/170-user-management is ahead at 14420e2): apps/management/lib/auth/server.ts:L43: blocker: The role additional field has input: true, and the public Better Auth POST /api/auth/sign-up/email and authenticated POST /api/auth/update-user accept writable additional fields; anyone can sign up as admin or an existing operator can update their own role to admin, bypassing every requireAdmin guard. Set input: false and assign roles only in the guarded admin actions. The local 14420e2 revision already contains this fix, but Forgejo still points at b828e0e at review submission; push the corrected revision before merging.

yuris reopened this pull request 2026-09-30 08:41:34 +00:00

yuris commented 2026-09-30 08:45:22 +00:00

Author

Owner

Copy link

Merged to main in squash commit ea97cf3c6178e6c738ef9188092ec06f0e4b37d2.

Merged to main in squash commit ea97cf3c6178e6c738ef9188092ec06f0e4b37d2.

yuris merged commit 6664e26909 into main 2026-09-30 08:57:18 +00:00

yuris deleted branch feat/170-user-management 2026-09-30 08:57:18 +00:00

yuris referenced this pull request from a commit 2026-09-30 08:57:20 +00:00

feat(management): add user management and role-based navigation (#171)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

yuris/garage!171

No description provided.