yuris/garage
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix(management): require explicit opt-in marker for production store deploy #121

Merged
yuris merged 1 commit from fix/79-store-deploy-guard into main 2026-09-28 20:53:12 +00:00
Conversation 1 Commits 1 Files changed 2 +50 -2
yuris commented 2026-09-28 20:52:38 +00:00
Owner
Copy link

Resolves #79

  • Require STORE_DEPLOY_ENABLED === "true" before dispatching production store deploy in requestStoreDeploy.
  • Decline dispatch and log visible warning via console.warn when URL and token are present but opt-in is not enabled.
  • Added and updated tests in deploy.test.ts covering unconfigured, configured without opt-in, configured with opt-in false, and configured with opt-in true.
Resolves #79 - Require `STORE_DEPLOY_ENABLED === "true"` before dispatching production store deploy in `requestStoreDeploy`. - Decline dispatch and log visible warning via `console.warn` when URL and token are present but opt-in is not enabled. - Added and updated tests in `deploy.test.ts` covering unconfigured, configured without opt-in, configured with opt-in false, and configured with opt-in true.
fix(management): require explicit opt-in marker for production store deploy (#79)
All checks were successful
Checks / test @garage/catalog (pull_request) Successful in 1m19s
Details
Checks / test garage (pull_request) Successful in 1m21s
Details
Checks / test garage-store (pull_request) Successful in 1m18s
Details
Checks / typecheck apps/management (pull_request) Successful in 1m35s
Details
Checks / lint (biome) (pull_request) Successful in 11s
Details
Checks / typecheck apps/store (pull_request) Successful in 1m20s
Details
042047030d
yuris reviewed 2026-09-28 20:53:04 +00:00
yuris left a comment
Copy link

VERDICT: approve

  • Requires explicit STORE_DEPLOY_ENABLED=true before dispatching production deploy workflows.
  • Logs visible warning when credentials are present but opt-in is absent, preventing accidental releases from non-production environments.
  • Unconfigured environments remain silent no-ops.
  • Comprehensive test coverage in deploy.test.ts.
VERDICT: approve - Requires explicit `STORE_DEPLOY_ENABLED=true` before dispatching production deploy workflows. - Logs visible warning when credentials are present but opt-in is absent, preventing accidental releases from non-production environments. - Unconfigured environments remain silent no-ops. - Comprehensive test coverage in `deploy.test.ts`.
yuris merged commit 5497ae6422 into main 2026-09-28 20:53:12 +00:00
yuris changed title from fix(management): require explicit opt-in marker for production store deploy (#79) to fix(management): require explicit opt-in marker for production store deploy 2026-09-28 21:09:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/garage!121
No description provided.