yuris/garage
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix(inventory): make prefix search deterministic and refuse ambiguous matches #119

Merged
yuris merged 1 commit from fix/81-find-inventory-prefix-ambiguity into main 2026-09-28 20:50:09 +00:00
Conversation 1 Commits 1 Files changed 2 +178 -6
yuris commented 2026-09-28 20:49:49 +00:00
Owner
Copy link

Resolves #81

Summary

  • Update findInventoryByPrefix to check for exact name match first via findInventoryByName.
  • Order prefix queries deterministically with .orderBy(asc(schema.inventory.itemName), asc(schema.inventory.id)).
  • Fetch up to 2 rows and refuse silent resolution when multiple rows match prefix (returns undefined) so callers do not guess or overwrite wrong inventory rows.
  • Add comprehensive tests in queries.test.ts covering exact match precedence, deterministic single match resolution, ambiguous match refusal, and edge cases.

Verification

  • direnv exec . pnpm verify:management passes (test: 441/441 passed across 20 files, lint: exit 0, typecheck: exit 0).
Resolves #81 ### Summary - Update `findInventoryByPrefix` to check for exact name match first via `findInventoryByName`. - Order prefix queries deterministically with `.orderBy(asc(schema.inventory.itemName), asc(schema.inventory.id))`. - Fetch up to 2 rows and refuse silent resolution when multiple rows match prefix (returns `undefined`) so callers do not guess or overwrite wrong inventory rows. - Add comprehensive tests in `queries.test.ts` covering exact match precedence, deterministic single match resolution, ambiguous match refusal, and edge cases. ### Verification - `direnv exec . pnpm verify:management` passes (test: 441/441 passed across 20 files, lint: exit 0, typecheck: exit 0).
fix(inventory): make prefix search deterministic and refuse ambiguous matches (#81)
All checks were successful
Checks / test garage (pull_request) Successful in 1m22s
Details
Checks / typecheck apps/management (pull_request) Successful in 1m35s
Details
Checks / lint (biome) (pull_request) Successful in 12s
Details
Checks / test @garage/catalog (pull_request) Successful in 1m15s
Details
Checks / test garage-store (pull_request) Successful in 1m18s
Details
Checks / typecheck apps/store (pull_request) Successful in 1m20s
Details
f040f6deae
yuris reviewed 2026-09-28 20:50:05 +00:00
yuris left a comment
Copy link

VERDICT: approve

  • Prefers exact name match before prefix matching.
  • Adds deterministic orderBy(asc(schema.inventory.itemName), asc(schema.inventory.id)).
  • Queries limit(2) and returns undefined on ambiguous multiple matches, preventing silent poisoning of item prices.
  • Unit tests in queries.test.ts verify all branches.
VERDICT: approve - Prefers exact name match before prefix matching. - Adds deterministic `orderBy(asc(schema.inventory.itemName), asc(schema.inventory.id))`. - Queries `limit(2)` and returns `undefined` on ambiguous multiple matches, preventing silent poisoning of item prices. - Unit tests in `queries.test.ts` verify all branches.
yuris merged commit 9171e43bb3 into main 2026-09-28 20:50:09 +00:00
yuris changed title from fix(inventory): make prefix search deterministic and refuse ambiguous matches (#81) to fix(inventory): make prefix search deterministic and refuse ambiguous matches 2026-09-28 21:09:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/garage!119
No description provided.