yuris/garage
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix(security): redact raw SQL in MCP tools and R2 config in uploads #118

Merged
yuris merged 1 commit from fix/77-mcp-sql-leak into main 2026-09-28 20:49:02 +00:00
Conversation 1 Commits 1 Files changed 10 +549 -78
yuris commented 2026-09-28 20:48:20 +00:00
Owner
Copy link

Resolves #77

  • Redact raw Drizzle SQL / driver error disclosure from MCP tools (create_purchase, update_purchase, delete_purchase, create_order, upload_receipt), while preserving safe ServiceRejection and ZodError messages and logging unexpected errors server-side.
  • In r2.ts, distinguish client-actionable errors (R2ClientError, e.g. unsupported MIME, file size limit) from infrastructure errors (missing env vars, S3 connection failure).
  • In uploads.ts, return 422 for client-actionable rejections and redact infrastructure errors to generic 500 without leaking Cloudflare account IDs, bucket names, or R2 endpoint domains.
Resolves #77 - Redact raw Drizzle SQL / driver error disclosure from MCP tools (`create_purchase`, `update_purchase`, `delete_purchase`, `create_order`, `upload_receipt`), while preserving safe `ServiceRejection` and `ZodError` messages and logging unexpected errors server-side. - In `r2.ts`, distinguish client-actionable errors (`R2ClientError`, e.g. unsupported MIME, file size limit) from infrastructure errors (missing env vars, S3 connection failure). - In `uploads.ts`, return 422 for client-actionable rejections and redact infrastructure errors to generic 500 without leaking Cloudflare account IDs, bucket names, or R2 endpoint domains.
fix(security): redact raw SQL in MCP tools and R2 config in uploads (#77)
All checks were successful
Checks / test @garage/catalog (pull_request) Successful in 1m14s
Details
Checks / test garage (pull_request) Successful in 1m21s
Details
Checks / test garage-store (pull_request) Successful in 1m18s
Details
Checks / lint (biome) (pull_request) Successful in 12s
Details
Checks / typecheck apps/management (pull_request) Successful in 1m35s
Details
Checks / typecheck apps/store (pull_request) Successful in 1m21s
Details
2e032e1447
yuris reviewed 2026-09-28 20:48:54 +00:00
yuris left a comment
Copy link

VERDICT: approve

  • Redacts raw Drizzle SQL, driver errors, and connection string fragments from MCP responses (purchases.ts, orders.ts, images.ts) to generic server errors while preserving ServiceRejection and ZodError.
  • Typed R2ClientError distinguishes client-actionable errors from infrastructure faults; upload routes no longer leak account IDs, bucket names, or r2.cloudflarestorage.com.
  • Full server-side error logging maintained.
  • Verified with unit and wiring tests in all affected surfaces.
VERDICT: approve - Redacts raw Drizzle SQL, driver errors, and connection string fragments from MCP responses (`purchases.ts`, `orders.ts`, `images.ts`) to generic server errors while preserving `ServiceRejection` and `ZodError`. - Typed `R2ClientError` distinguishes client-actionable errors from infrastructure faults; upload routes no longer leak account IDs, bucket names, or `r2.cloudflarestorage.com`. - Full server-side error logging maintained. - Verified with unit and wiring tests in all affected surfaces.
yuris merged commit 103343c127 into main 2026-09-28 20:49:02 +00:00
yuris changed title from fix(security): redact raw SQL in MCP tools and R2 config in uploads (#77) to fix(security): redact raw SQL in MCP tools and R2 config in uploads 2026-09-28 21:09:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/garage!118
No description provided.