yuris/garage
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix(store): provide mobile scroll clearance for sticky buy bar #117

Merged
yuris merged 1 commit from fix/89-mobile-sticky-buy into main 2026-09-28 20:43:29 +00:00
Conversation 1 Commits 1 Files changed 2 +5 -2
yuris commented 2026-09-28 20:42:38 +00:00
Owner
Copy link

Resolves #89

  • Provide clearance on scroll container via body:has(.sticky-buy) { padding-bottom: 69px; } inside @media (max-width: 700px).
  • Remove unneeded padding-bottom: 96px; on .pdp.
  • Regenerate globals.css cleanly via port-design.
Resolves #89 - Provide clearance on scroll container via `body:has(.sticky-buy) { padding-bottom: 69px; }` inside `@media (max-width: 700px)`. - Remove unneeded `padding-bottom: 96px;` on `.pdp`. - Regenerate `globals.css` cleanly via `port-design`.
fix(store): provide mobile scroll clearance for sticky buy bar (#89)
All checks were successful
Checks / test garage (pull_request) Successful in 1m23s
Details
Checks / test garage-store (pull_request) Successful in 1m17s
Details
Checks / test @garage/catalog (pull_request) Successful in 1m13s
Details
Checks / typecheck apps/management (pull_request) Successful in 1m36s
Details
Checks / lint (biome) (pull_request) Successful in 11s
Details
Checks / typecheck apps/store (pull_request) Successful in 1m20s
Details
be7a7e986e
yuris reviewed 2026-09-28 20:43:25 +00:00
yuris left a comment
Copy link

VERDICT: approve

  • Reserves 69px clearance on body:has(.sticky-buy) in @media (max-width: 700px) so footer links remain reachable on mobile PDP.
  • Removes redundant 96px padding on .pdp.
  • Cleanly generated through port-design script from tokens.css.
  • Verified with headless browser and existing test suite.
VERDICT: approve - Reserves 69px clearance on `body:has(.sticky-buy)` in `@media (max-width: 700px)` so footer links remain reachable on mobile PDP. - Removes redundant 96px padding on `.pdp`. - Cleanly generated through `port-design` script from `tokens.css`. - Verified with headless browser and existing test suite.
yuris merged commit 7ce72231ff into main 2026-09-28 20:43:29 +00:00
yuris changed title from fix(store): provide mobile scroll clearance for sticky buy bar (#89) to fix(store): provide mobile scroll clearance for sticky buy bar 2026-09-28 20:46:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/garage!117
No description provided.