fix(management): make mobile bottom navigation items uniform in width #175

Merged

yuris merged 1 commit from fix/174-uniform-bottom-nav-widths into main

2026-09-30 12:40:34 +00:00

yuris commented

2026-09-30 12:38:30 +00:00

Owner

Closes #174

What changed

Updated the mobile bottom <nav> container in apps/management/components/dashboard-nav.tsx from justify-around px-2 to px-1.
Added flex-1 basis-0 min-w-0 and set padding to px-1 on all 5 bottom navigation items (4 links and 1 settings trigger button) so each item occupies equal width regardless of label text length.
Added truncate max-w-full text-center to all label spans to prevent text wrapping or overflowing on small screens.

Verified

pnpm --filter garage test: passed (27 files, 516 tests passed).
pnpm --filter garage typecheck: passed.
.forgejo/scripts/biome-gate.sh: passed with no regressions.
biome check apps/management/components/dashboard-nav.tsx: clean.

Deviations

None.

Note: Merging to main triggers production deployment via .forgejo/workflows/build-publish.yml.

Closes #174 ### What changed - Updated the mobile bottom `<nav>` container in `apps/management/components/dashboard-nav.tsx` from `justify-around px-2` to `px-1`. - Added `flex-1 basis-0 min-w-0` and set padding to `px-1` on all 5 bottom navigation items (4 links and 1 settings trigger button) so each item occupies equal width regardless of label text length. - Added `truncate max-w-full text-center` to all label spans to prevent text wrapping or overflowing on small screens. ### Verified - `pnpm --filter garage test`: passed (27 files, 516 tests passed). - `pnpm --filter garage typecheck`: passed. - `.forgejo/scripts/biome-gate.sh`: passed with no regressions. - `biome check apps/management/components/dashboard-nav.tsx`: clean. ### Deviations None. > Note: Merging to main triggers production deployment via `.forgejo/workflows/build-publish.yml`.

yuris added 1 commit

2026-09-30 12:38:30 +00:00

fix(management): make mobile bottom navigation items uniform in width

Checks / test @garage/catalog (pull_request) Successful in 1m15s

Details

Checks / test garage (pull_request) Successful in 1m27s

Details

Checks / typecheck apps/management (pull_request) Successful in 1m39s

Details

Checks / lint (biome) (pull_request) Successful in 12s

Details

Checks / typecheck apps/store (pull_request) Successful in 1m21s

Details

Checks / test garage-store (pull_request) Successful in 1m19s

Details

07ff656fc5

yuris commented

2026-09-30 12:40:12 +00:00

Author

Owner

VERDICT: approve
Reviewed PR #175 against Issue #174: the mobile

now uses px-1 without justify-around; all four Link items and the Pengaturan button have flex-1 basis-0 min-w-0, px-1 py-1, and min-h-[44px] justify-center; both label templates apply truncate max-w-full text-center to all five labels. The diff touches only dashboard-nav.tsx, with no unrelated changes or identified regressions. The PR reports pnpm --filter garage test, pnpm --filter garage typecheck, and .forgejo/scripts/biome-gate.sh passed locally; Forgejo CI is still pending at review time.

VERDICT: approve Reviewed PR #175 against Issue #174: the mobile <nav> now uses px-1 without justify-around; all four Link items and the Pengaturan button have flex-1 basis-0 min-w-0, px-1 py-1, and min-h-[44px] justify-center; both label templates apply truncate max-w-full text-center to all five labels. The diff touches only dashboard-nav.tsx, with no unrelated changes or identified regressions. The PR reports pnpm --filter garage test, pnpm --filter garage typecheck, and .forgejo/scripts/biome-gate.sh passed locally; Forgejo CI is still pending at review time.

yuris merged commit 5ff16ee0ec into main

2026-09-30 12:40:34 +00:00

yuris deleted branch fix/174-uniform-bottom-nav-widths

2026-09-30 12:40:34 +00:00

yuris referenced this pull request from a commit

2026-09-30 12:40:35 +00:00

fix(management): make mobile bottom navigation items uniform in width (#175)