Reducer args encoding is hand-rolled #4

New issue

Closed

opened 2026-08-19 06:49:19 +00:00 by yuris · 1 comment

yuris commented

2026-08-19 06:49:19 +00:00

Owner

connection.call_reducer sends args as a raw Lua array — correct only for positional product args. Complex types (sum types, nested) need schema-driven encoding.

Decide: extend hand-rolled encoders per-shape vs schema-driven codegen
Cover: strings, numbers, bools, arrays, nested tables
Tests for each shape

ponytail: hand-rolled until a real module needs sum types.

`connection.call_reducer` sends `args` as a raw Lua array — correct only for positional product args. Complex types (sum types, nested) need schema-driven encoding. - [ ] Decide: extend hand-rolled encoders per-shape vs schema-driven codegen - [ ] Cover: strings, numbers, bools, arrays, nested tables - [ ] Tests for each shape ponytail: hand-rolled until a real module needs sum types.

yuris added the

area:protocol

phase:core

labels

2026-08-19 06:49:19 +00:00

yuris added this to the v0.1 — vertical slice milestone

2026-08-19 06:50:04 +00:00

yuris commented

2026-08-19 07:37:34 +00:00

Author

Owner

Resolved in ee90548 by observation rather than guesswork.

The wire format is JsonFormat::Single = ByteString — reducer args are a JSON string containing JSON:

{"CallReducer":{"reducer":"send_message","args":"[\"yuris\",\"hi\"]","request_id":2,"flags":0}}

protocol.encode_client now takes a Lua array for args and double-encodes it, passing a pre-encoded string through untouched. Verified end to end: the captured TransactionUpdate frames are responses to exactly these calls committing on a live 2.8.2 server.

Still open in principle: args whose types are sum types or nested products. Same rule applies (SATS-JSON inside the string), but the test module doesn't exercise them — revisit when a real module needs one.

Resolved in ee90548 by observation rather than guesswork. The wire format is `JsonFormat::Single = ByteString` — reducer args are a JSON **string containing JSON**: ``` {"CallReducer":{"reducer":"send_message","args":"[\"yuris\",\"hi\"]","request_id":2,"flags":0}} ``` `protocol.encode_client` now takes a Lua array for `args` and double-encodes it, passing a pre-encoded string through untouched. Verified end to end: the captured `TransactionUpdate` frames are responses to exactly these calls committing on a live 2.8.2 server. Still open in principle: args whose types are sum types or nested products. Same rule applies (SATS-JSON inside the string), but the test module doesn't exercise them — revisit when a real module needs one.

yuris closed this issue

2026-08-19 07:37:34 +00:00

yuris referenced this issue from a commit

2026-08-19 08:58:13 +00:00

schema: generate table descriptors from the live server

yuris referenced this issue

2026-08-19 09:52:10 +00:00

Procedures: CallProcedure + ProcedureResult #11

yuris referenced this issue

2026-08-19 16:11:43 +00:00

cache: report a pk row change as one update event #34