yuris/life-service
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages 1 Wiki Activity Actions

fix(tasks): replace old strength on strength-only patch #111

Merged
yuris merged 1 commit from fix/task-strength-patch into main 2026-09-23 22:36:08 +00:00
Conversation 1 Commits 1 Files changed 2 +62 -2
yuris commented 2026-09-23 22:35:24 +00:00
Owner
Copy link

Replace old commitment strength on a strength-only patch while preserving other categories and refusing conflicting strengths.

Replace old commitment strength on a strength-only patch while preserving other categories and refusing conflicting strengths.
fix(tasks): replace old strength on strength-only patch
All checks were successful
CI / Format, Lint & Test (Manual) (pull_request) Has been skipped
Details
CI / Commit Conventions (pull_request) Successful in 4s
Details
a927345e03
yuris reviewed 2026-09-23 22:35:58 +00:00
yuris left a comment
Copy link

Reviewed the complete diff. TaskPatch::effective_categories strips existing commitment strengths when categories are omitted so that a strength-only patch replaces the declared strength while preserving all non-strength categories. If conflicting strengths are passed in categories alongside strength, it is rejected with 422 Unprocessable Entity. Unit tests and full suite pass cleanly.

Reviewed the complete diff. TaskPatch::effective_categories strips existing commitment strengths when categories are omitted so that a strength-only patch replaces the declared strength while preserving all non-strength categories. If conflicting strengths are passed in categories alongside strength, it is rejected with 422 Unprocessable Entity. Unit tests and full suite pass cleanly.
yuris merged commit 1d96d998fa into main 2026-09-23 22:36:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/life-service!111
No description provided.