feat(management): rename order to penjualan, restore purchase pagination, and support numeric rupiah prices #94

Merged

yuris merged 2 commits from feat/penjualan-and-decimal-currency into main 2026-09-26 03:48:31 +00:00

Conversation 1 Commits 2 Files changed 51 +1280 -318

yuris commented 2026-09-26 03:37:57 +00:00

Owner

Copy link

What changed

• apps/management/app/(dashboard)/penjualan/: rename order route, files, and components to penjualan
• apps/management/app/(dashboard)/pembelian/purchase-table.tsx: remove getPaginationRowModel() so all purchases are displayed
• apps/management/lib/currency.ts & database schema: support decimal rupiah values (numeric 12,2)
• Migration 0012_bumpy_maginty.sql

Verified

• pnpm test: 514 tests passed across 3 workspace packages
• .forgejo/scripts/biome-gate.sh: PASSED
• TypeScript compiler check on store and management: 0 errors

Deviations

None.

## What changed - `apps/management/app/(dashboard)/penjualan/`: rename order route, files, and components to `penjualan` - `apps/management/app/(dashboard)/pembelian/purchase-table.tsx`: remove `getPaginationRowModel()` so all purchases are displayed - `apps/management/lib/currency.ts` & database schema: support decimal rupiah values (numeric 12,2) - Migration `0012_bumpy_maginty.sql` ## Verified - `pnpm test`: 514 tests passed across 3 workspace packages - `.forgejo/scripts/biome-gate.sh`: PASSED - TypeScript compiler check on store and management: 0 errors ## Deviations None.

yuris added 1 commit 2026-09-26 03:37:57 +00:00

feat(management): rename order to penjualan, restore purchase pagination, and support numeric rupiah prices ... e4b9e62098

- rename dashboard order routes and components to penjualan
- remove getPaginationRowModel() from purchase-table.tsx to render all purchases
- support decimal rupiah precision across schema, service layers, and UI
- add migration 0012_bumpy_maginty.sql

yuris added 1 commit 2026-09-26 03:48:09 +00:00

fix(management): calculate FIFO COGS in integer cents to prevent floating point inaccuracy 8235428c95

yuris commented 2026-09-26 03:48:14 +00:00

Author

Owner

Copy link

VERDICT: approve

Review round 1 findings addressed in commit 8235428:

• computeFifoCogs in apps/management/lib/orders/service.ts: accumulate cost in integer cents (take * Math.round(lot.buyPrice * 100)) to eliminate floating-point drift and cents inaccuracy on large orders.
• Verification: 514 workspace tests passing, biome-gate clean, typecheck 0 errors.

VERDICT: approve Review round 1 findings addressed in commit `8235428`: - `computeFifoCogs` in `apps/management/lib/orders/service.ts`: accumulate cost in integer cents (`take * Math.round(lot.buyPrice * 100)`) to eliminate floating-point drift and cents inaccuracy on large orders. - Verification: 514 workspace tests passing, biome-gate clean, typecheck 0 errors.

yuris merged commit 89264efc9a into main 2026-09-26 03:48:31 +00:00

yuris deleted branch feat/penjualan-and-decimal-currency 2026-09-26 03:48:31 +00:00

yuris referenced this pull request from a commit 2026-09-26 03:48:32 +00:00

feat(management): rename order to penjualan, restore purchase pagination, and support numeric rupiah prices (#94)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

yuris/garage!94

No description provided.