store: cover cart.ts with tests, drop unused Tailwind, fix stale copy #49

New issue

Closed

opened 2026-08-27 06:35:53 +00:00 by yuris · 0 comments

yuris commented

2026-08-27 06:35:53 +00:00

Owner

Three unrelated small things, batched because each is a few lines and none deserves its own issue.

1. `lib/cart.ts` has no test

It is the only module in apps/store/lib without one, and it is the riskiest: it owns money-adjacent state, treats localStorage as a trust boundary via isLine(), keeps a module-level store with a listener Set, and syncs across tabs on StorageEvent. #41 and #47 both change the cart line shape, so the coverage should exist before they land, not after.

Worth asserting: a malformed stored value yields an empty cart rather than throwing; add of an existing slug increments instead of duplicating; setQty(0) removes the line; total excludes null-price lines and hasUnpricedLine reports them; listeners fire on mutation. The hook needs no DOM — export the store functions and test those, keeping useCart as the thin wrapper.

2. Tailwind is installed but never used

tailwindcss v4 and @tailwindcss/postcss are in apps/store devDependencies and wired in postcss.config.mjs, but globals.css has no @import "tailwindcss" and no component uses a utility class. All styling is the plain-CSS token system from #33. Delete both dependencies and the postcss wiring — it is install weight and a misleading signal to the next reader about how this app is styled. (apps/management genuinely uses Tailwind; leave it alone.)

3. Pre-cart copy on the products page

app/products/page.tsx metadata and lead still say "tanya stok dan harga lewat WhatsApp". Prices and a cart shipped in #39 — the copy predates them and now undersells the page. Reword to match the shipped behaviour.

Acceptance

pnpm --filter garage-store test covers the cart cases above and passes. pnpm install no longer pulls Tailwind for the store, and pnpm --filter garage-store build produces a visually identical site (the postcss pipeline was a no-op). No page still tells visitors to ask for prices they can see.

Three unrelated small things, batched because each is a few lines and none deserves its own issue. ### 1. `lib/cart.ts` has no test It is the only module in `apps/store/lib` without one, and it is the riskiest: it owns money-adjacent state, treats `localStorage` as a trust boundary via `isLine()`, keeps a module-level store with a listener `Set`, and syncs across tabs on `StorageEvent`. #41 and #47 both change the cart line shape, so the coverage should exist before they land, not after. Worth asserting: a malformed stored value yields an empty cart rather than throwing; `add` of an existing slug increments instead of duplicating; `setQty(0)` removes the line; `total` excludes null-price lines and `hasUnpricedLine` reports them; listeners fire on mutation. The hook needs no DOM — export the store functions and test those, keeping `useCart` as the thin wrapper. ### 2. Tailwind is installed but never used `tailwindcss` v4 and `@tailwindcss/postcss` are in `apps/store` devDependencies and wired in `postcss.config.mjs`, but `globals.css` has no `@import "tailwindcss"` and no component uses a utility class. All styling is the plain-CSS token system from #33. Delete both dependencies and the postcss wiring — it is install weight and a misleading signal to the next reader about how this app is styled. (`apps/management` genuinely uses Tailwind; leave it alone.) ### 3. Pre-cart copy on the products page `app/products/page.tsx` metadata and lead still say *"tanya stok dan harga lewat WhatsApp"*. Prices and a cart shipped in #39 — the copy predates them and now undersells the page. Reword to match the shipped behaviour. ### Acceptance `pnpm --filter garage-store test` covers the cart cases above and passes. `pnpm install` no longer pulls Tailwind for the store, and `pnpm --filter garage-store build` produces a visually identical site (the postcss pipeline was a no-op). No page still tells visitors to ask for prices they can see.

yuris referenced this issue from a pull request that will close it,

2026-08-27 07:45:36 +00:00

test(store): cover the cart store, drop unused Tailwind, refresh pre-cart copy #51

yuris referenced this issue

2026-08-27 08:59:37 +00:00

feat(catalog): schema v3 — fitment, oemNumbers, priceUpdatedAt, availability tri-state #53

yuris closed this issue

2026-08-27 09:01:18 +00:00

yuris referenced this issue

2026-08-27 11:01:05 +00:00

feat(catalog): schema v3 — fitment, oemNumbers, priceUpdatedAt, availability tri-state #53

yuris referenced this issue