yuris/garage
1
0
Fork 0
Code Issues 7 Pull requests 2 Projects Releases Packages 1 Wiki Activity Actions

refactor: shrink duplicated code and dead config #20

Merged
yuris merged 1 commit from refactor/shrink-and-trivial into main 2026-07-18 06:57:22 +00:00
Conversation 1 Commits 1 Files changed 31 +428 -503
yuris commented 2026-07-18 06:18:08 +00:00
Owner
Copy link

Summary

  • deduplicate report order/purchase queries and inventory lookups
  • centralize manual stock adjustments
  • collapse duplicated report tables and movement badges
  • remove repeated session/type/config plumbing
  • remove dead db:seed, store fields/helpers, and unused exports

Verification

  • management TypeScript: passed
  • store TypeScript: passed
  • management tests: 25 passed
  • store tests: 6 passed
  • management production build: passed (Next.js emitted one existing NFT tracing warning from dynamic env file access)
  • git diff --check: passed

DetailsShell extraction was intentionally skipped: existing DetailsPanel already owns the reusable shell, and extracting the remaining entity-specific wrappers increased code size.

## Summary - deduplicate report order/purchase queries and inventory lookups - centralize manual stock adjustments - collapse duplicated report tables and movement badges - remove repeated session/type/config plumbing - remove dead `db:seed`, store fields/helpers, and unused exports ## Verification - management TypeScript: passed - store TypeScript: passed - management tests: 25 passed - store tests: 6 passed - management production build: passed (Next.js emitted one existing NFT tracing warning from dynamic env file access) - `git diff --check`: passed DetailsShell extraction was intentionally skipped: existing `DetailsPanel` already owns the reusable shell, and extracting the remaining entity-specific wrappers increased code size.
yuris reviewed 2026-07-18 06:51:22 +00:00
yuris left a comment
Copy link

Reviewed the full diff. No correctness issues found. Verification: pnpm test passed (31 tests total: management 25, store 6, catalog 5); TypeScript checks passed for both apps.

Reviewed the full diff. No correctness issues found. Verification: `pnpm test` passed (31 tests total: management 25, store 6, catalog 5); TypeScript checks passed for both apps.
yuris merged commit ef16002ec4 into main 2026-07-18 06:57:22 +00:00
yuris deleted branch refactor/shrink-and-trivial 2026-07-18 06:57:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
yuris/garage!20
No description provided.